Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react/no-this-in-sfc #1737

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Add react/no-this-in-sfc #1737

merged 1 commit into from
Feb 20, 2018

Conversation

caub
Copy link

@caub caub commented Feb 19, 2018

No description provided.

@ljharb ljharb self-assigned this Feb 19, 2018
ljharb
ljharb requested changes Feb 19, 2018
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this is a change I already have locally as I prepare for the next major bump. I'll leave this open in the interim.

@ljharb ljharb merged commit ff1c121 into airbnb:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees

@ljharb ljharb

Labels
semver-breaking: guide change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caub @ljharb