Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only one newline at the end #1794

Merged
merged 1 commit into from
May 2, 2018
Merged

only one newline at the end #1794

merged 1 commit into from
May 2, 2018

Conversation

graingert
Copy link
Contributor

it seems 'no-multiple-empty-lines'.maxEOF is out by one

@graingert
Copy link
Contributor Author

Good:

export default 'foo';\n

Bad:

export default 'foo';\n\n

@ljharb
Copy link
Collaborator

ljharb commented Apr 30, 2018

This seems like an eslint issue then - has one been filed upstream?

@graingert
Copy link
Contributor Author

No it seems intentional https://github.com/eslint/eslint/blob/fc7f404365e87fb6ee4f30149e486229cda4eb2e/lib/rules/no-multiple-empty-lines.js#L61

graingert added a commit to graingert/eslint that referenced this pull request May 1, 2018
@graingert
fix 'no-multiple-empty-lines'.maxEOF out by one
04361b4 
airbnb/javascript#1794
@graingert graingert mentioned this pull request May 1, 2018
Closed
@ljharb ljharb merged commit 2d97799 into airbnb:master May 2, 2018
@JBallin JBallin mentioned this pull request Jun 10, 2019
Merged
@Luis729 Luis729 mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor: tighten rules to match guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @ljharb