Add no-unused-vars to README #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jun 8, 2018
README.md
Outdated
| z = z + 1; | ||
|
|
||
| // Unused function arguments. | ||
| function getY(x, y) { |
There was a problem hiding this comment.
in this case, x won't be reported because y is used. if you return x, however, then y would be reported.
There was a problem hiding this comment.
Interesting, I did not know that. Will fix.
|
|
||
| alert(getXPlusY(x, y)); | ||
|
|
||
| // 'type' is ignored even if unused because it has a rest property sibling. |
There was a problem hiding this comment.
let's elaborate on why: this is a form of extracting an object that omits specific keys.
This documents the enforced but currently undocumented `no-unused-vars` rule with a brief description, examples, and noting the `"ignoreRestSiblings": true` option.
|
Thanks, I amended the commit with your feedback. |
ljharb
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the enforced but currently undocumented
no-unused-varsrule with a brief description, examples, and noting the"ignoreRestSiblings": trueoption.