-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[major][guide][eslint config] Simplifies no-mixed-operators
#1864
Conversation
…ors` - adds warning on mixing `/` and `*` arithmetic operators - removes warnings on mixing `**` and arithmetic operators - removes warning on mixing `in` and `instanceof` - removes warning on mixing `~` with other bitwise operators - removes mixing of assignment operators with comparison operators
The description suggests that it only removes warnings; that suggests this is a patch. Confirm? |
@ljharb there's actually one addition, to warn on mixing |
18dc21c
to
bcd874c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Holding off on merging this until #1834 is out.
bcd874c
to
c85639f
Compare
@ljharb can we get this into the next breaking release? |
yep, i'm going to make a sweep before the next release and bring in all semver-majors. |
c85639f
to
f6acb78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=it+is+time
**
and arithmetic operatorsin
andinstanceof
~
with other bitwise operators*
and/
fixed warnings: