Add jest.setup.js to import/no-extraneous-dependencies devDependencies #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….setup.js to devDeps
ljharb
approved these changes
Feb 5, 2019
ljharb
force-pushed
the
add-jest-setup-file
branch
from
a9e0ee3 to
96f95fa
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team - Thank you for all of your excellent work on this project. 🙌 I use Jest on a number of projects. A pattern Jest users utilize is moving setup to a separate
jest.setup.jsfile. I would like to use devDependencies in this file without receiving an error fromimport/no-extraneous-dependencies. Would you be open to adding a new pattern to theimport/no-extraneous-dependenciesrule? Please let me know if you have questions or would like me to make changes. Thank you in advance!