Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example 4.7 for arrays method callbacks #2004

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

mapb
Copy link
Contributor

@mapb mapb commented Feb 13, 2019

This PR removes an unnecessary expression from the example. The line was part of the non-working example and should not be part of the best practice example.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the good example works without that line, and the bad example is bad without it, I've gone ahead and also removed it from the bad example. Thanks!

@ljharb ljharb merged commit 495a62a into airbnb:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants