Add explanations and examples for .bind and arrow functions in render path in react components #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensive
commented
Feb 24, 2019
ljharb
requested changes
Feb 24, 2019
Ensive
force-pushed
the
enhance/add-explanations-and-examples-for-bind-and-arrow-functions-in-react-components
branch
2 times, most recently
from
e954a7c to
2be0e89
Compare
ljharb
reviewed
Feb 24, 2019
|
@ljharb |
ljharb
approved these changes
Feb 25, 2019
ljharb
force-pushed
the
enhance/add-explanations-and-examples-for-bind-and-arrow-functions-in-react-components
branch
from
9fe63b2 to
be07f7a
Compare
Ensive
deleted the
enhance/add-explanations-and-examples-for-bind-and-arrow-functions-in-react-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deeply researched the topic regarding arrow functions and
.bindusage within React components (specifically render path). This PR is my proposal to update the javascript styleguide (React page).Let me know your thoughts.
Shall we split the example with appropriate usage of arrow functions into two:
eventobject to another function).mapor other cases (but in this case creating a separate function outside of render path is a better practice)Any suggestions on editing are welcome.
Closes #1995