Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore property modifications of staticContext params #2029

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Ignore property modifications of staticContext params #2029

merged 1 commit into from
Apr 28, 2019
+1 −0

Conversation

jnields
Copy link

@jnields jnields commented Apr 27, 2019

Resolves #1639

@ljharb
[eslint config] [base] [patch] Ignore property modifications of `stat…
1310ade 
…icContext` params

React Router passes a `staticContext` property to children to allow
signalling status codes and redirected URLs, by allowing children to
assign property values to it during render
@ljharb ljharb force-pushed the master branch 3 times, most recently from 9fe9c2a to 1310ade Compare April 28, 2019 06:53
@ljharb ljharb merged commit 1310ade into airbnb:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: loosen/fix/document rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add staticContext to list of no-param-reassign "ignorePropertyModificationsFor"
2 participants
@jnields @ljharb