Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a max line length of 100 characters #639

Merged
merged 5 commits into from
Dec 24, 2015
Merged

Define a max line length of 100 characters #639

merged 5 commits into from
Dec 24, 2015

Commits on Dec 24, 2015

  1. Add section 18.12 on line length

    @chrisngobanh
    chrisngobanh committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    b7fbc7b View commit details
    Browse the repository at this point in the history

  2. Update .jshintrc with new line length

    @chrisngobanh
    chrisngobanh committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    d11f266 View commit details
    Browse the repository at this point in the history

  3. Enable ESLint rule on limiting maxiumum length of line (max-len) 

    I moved the rule from legacy.js to style.js and enabled it
    @chrisngobanh
    chrisngobanh committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    69d3327 View commit details
    Browse the repository at this point in the history

  4. Reword section 6.2 to recognize the line length

    @chrisngobanh
    chrisngobanh committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    f1c249b View commit details
    Browse the repository at this point in the history

  5. Address comments in airbnb#639 

    [eslint] Add comment above `max-len` rule with link to its docs
[eslint] Change tab width for `max-len` rule from 4 to 2
[eslint] Replace double quotes around `max-len` with single quotes
[eslint] Use object form of `max-len` and include all of the options
    @chrisngobanh
    chrisngobanh committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    e2e4724 View commit details
    Browse the repository at this point in the history