Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

permissions bug fixes (#5559) #74

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

timifasubaa
Copy link

@timifasubaa timifasubaa commented Aug 3, 2018

(cherry picked from commit 1e15566)

This PR fixes a few silly errors I made in my last PRs. @graceguo-supercat @michellethomas

(cherry picked from commit 1e15566)
@timifasubaa timifasubaa force-pushed the cherrypick_permissions_fixes branch from 0f00376 to 63eb6ee Compare August 3, 2018 19:25
Copy link
Collaborator

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #74 into airbnb-master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           airbnb-master     #74   +/-   ##
=============================================
  Coverage           65.6%   65.6%           
=============================================
  Files                346     346           
  Lines              21858   21858           
  Branches            2425    2425           
=============================================
  Hits               14339   14339           
  Misses              7508    7508           
  Partials              11      11
Impacted Files Coverage Δ
superset/views/core.py 73.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bdc0f...63eb6ee. Read the comment docs.

@timifasubaa timifasubaa merged commit fb6b304 into airbnb-master Aug 3, 2018
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* Convert translation to typescript

* update input types

* update travis

* update node version
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
@john-bodley john-bodley deleted the cherrypick_permissions_fixes branch June 8, 2022 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants