Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fix edge case around NaN values (#4964) #92

Merged

Conversation

john-bodley
Copy link
Collaborator

(cherry picked from commit e1618dd)

This PR fixes an issue reported in the #superset-goalie channel, Unable to parse string "NaN" at position 0.

to: @graceguo-supercat @kristw @michellethomas @timifasubaa

@codecov-io
Copy link

Codecov Report

Merging #92 into airbnb-master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           airbnb-master      #92   +/-   ##
==============================================
  Coverage          63.25%   63.25%           
==============================================
  Files                351      351           
  Lines              22034    22034           
  Branches            2468     2468           
==============================================
  Hits               13937    13937           
  Misses              8085     8085           
  Partials              12       12
Impacted Files Coverage Δ
superset/viz.py 80.89% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08017a...acda62c. Read the comment docs.

@john-bodley john-bodley merged commit 5df10ab into airbnb:airbnb-master Aug 15, 2018
@john-bodley john-bodley deleted the john-bodley-cherry-pick-4964 branch August 15, 2018 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants