[bugfix] bignumber comparison wrong with neg values (#1743)

* [bugfix] bignumber comparison wrong with neg values * Handling zero div
apache · Dec 4, 2016 · a3106bc · a3106bc
1 parent b045075
commit a3106bc
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/superset/assets/visualizations/big_number.js b/superset/assets/visualizations/big_number.js
@@ -35,7 +35,10 @@ function bigNumberVis(slice) {
       if (json.compare_lag > 0) {
         const pos = data.length - (json.compare_lag + 1);
         if (pos >= 0) {
-          vCompare = (v / data[pos][1]) - 1;
+          const vAnchor = data[pos][1];
+          if (vAnchor !== 0) {
+            vCompare = (v - vAnchor) / Math.abs(vAnchor);
+          }
         }
       }
       const dateExt = d3.extent(data, (d) => d[0]);