[bugfix] bignumber comparison wrong with neg values #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
bugfix_bignumber_neg
branch
from
9ff9130 to
113bbc2
Compare
bkyryliuk
reviewed
Dec 2, 2016
| @@ -35,7 +35,8 @@ function bigNumberVis(slice) { | |||
| if (json.compare_lag > 0) { | |||
| const pos = data.length - (json.compare_lag + 1); | |||
| if (pos >= 0) { | |||
| vCompare = (v / data[pos][1]) - 1; | |||
| const vAnchor = data[pos][1]; | |||
There was a problem hiding this comment.
Yes....vAnchor is basically a data point- If there is no check over data[pos][1], then this could lead to arithmetic exception.
|
Avoiding the zero division, currently it just won't show that section if that's the case. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested that the example slices renders properly.