Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log of non existing variable #147

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Remove log of non existing variable #147

merged 1 commit into from
Dec 9, 2021

Conversation

galleon
Copy link
Contributor

@galleon galleon commented Dec 9, 2021

The doIProceedvariable is coming from a former codebase and was not removed everywhere causing an error when run.

dbarbier
dbarbier approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@dbarbier dbarbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also remove most of these logs, less code less bugs.

@galleon galleon merged commit 282790a into airbus:master Dec 9, 2021
@galleon galleon deleted the gal/fix_the_do_i_proceed branch December 9, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarbier dbarbier dbarbier approved these changes

@nhuet nhuet nhuet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galleon @dbarbier @nhuet