Fix typo for isJsxFragment. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isJsxFramgment -> isJsxFragment
|
Any idea on the ci failure? Looks to be an issue with publishing to coveralls. |
ajafff
reviewed
Dec 14, 2017
typeguard/node.ts
Outdated
| @@ -357,7 +357,7 @@ export function isJsxExpression(node: ts.Node): node is ts.JsxExpression { | |||
| return node.kind === ts.SyntaxKind.JsxExpression; | |||
| } | |||
|
|
|||
| export function isJsxFramgment(node: ts.Node): node is ts.JsxFragment { | |||
| export function isJsxFragment(node: ts.Node): node is ts.JsxFragment { | |||
There was a problem hiding this comment.
I'd rather keep the misnamed function around to avoid a breaking change. It can just defer to the new function and is marked as @deprecated in jsdoc.
There was a problem hiding this comment.
That is a really good idea. I will make that change.
ajafff
approved these changes
Dec 14, 2017
|
Thanks @dmiller9911 |
|
This change is released in v2.13.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isJsxFramgment -> isJsxFragment