Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CSS Syntax Highlighter #5676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimChinye
Copy link

@TimChinye TimChinye commented Nov 15, 2024

Updated the mode-css.js file to the latest CSS specifications, using MDN provided information and Ace Linters (As of May 29).

Issue #, if available: #5559

Description of changes: Updated the mode-css.js file to latest CSS specifications, using MDN provided information and Ace Linters.

Additional Info:

  • Ace Linters supports Non-standard and Deprecated code, but not Experimental - this CSS Mode complies with that.
  • khz and hz units are no longer supported, as they're technically experimental (as in - they have not use "yet"), gd unit has been removed as it's seemingly a myth. Was mentioned in a single version of a CSS specification with zero information to go along with it, and removed within a year.
  • Still does not take into consideration the new CSS Nesting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Original Issue: ajaxorg/ace-builds#264 (comment)

Pull Request Checklist:

Updated the mode-css.js file to the latest CSS specifications, using MDN provided information and [Ace Linters](https://github.com/mkslanc/ace-linters) (As of May 29).
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (6dfb903) to head (a48a550).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5676   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files         598      598           
  Lines       43680    43680           
  Branches     7204     7204           
=======================================
  Hits        38009    38009           
  Misses       5671     5671           
Flag Coverage Δ
unittests 87.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant