Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popup): add support for skipping filtering with prefix by introducing skipFilter flag #5740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nlujjawal
Copy link
Contributor

@nlujjawal nlujjawal commented Feb 7, 2025

Description of changes:
Add support for skipping filtering with prefix by introducing skipFilter flag which will all the popup item to not get filtered out incase if the popup item value is not matching the prefix.

Pull Request Checklist:

@nlujjawal nlujjawal requested a review from nightwing February 7, 2025 12:28
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (09fba2e) to head (1aef671).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5740   +/-   ##
=======================================
  Coverage   87.06%   87.07%           
=======================================
  Files         598      598           
  Lines       43722    43749   +27     
  Branches     7164     7165    +1     
=======================================
+ Hits        38067    38094   +27     
  Misses       5655     5655           
Flag Coverage Δ
unittests 87.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/autocomplete.js Outdated Show resolved Hide resolved
src/autocomplete.js Outdated Show resolved Hide resolved
src/autocomplete.js Outdated Show resolved Hide resolved
@nlujjawal nlujjawal force-pushed the popup_changes branch 3 times, most recently from fb87827 to e73ad76 Compare February 7, 2025 16:22
@nlujjawal nlujjawal changed the title feat(popup): add support for click-callback on popup items feat(popup): add support for skipping filtering with prefix by introducing skipFilter flag Feb 7, 2025
@nlujjawal nlujjawal requested review from akoreman and xyos February 7, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants