support autocd option #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bash, when autocd option is set and user enters a directory name as a command, it results in a very specific call to cd: cd -- [directory name] zoxide's directory changing function passes all arguments to __zoxide_z as is, including the "--" first argument. By detecting this and skipping the first argument changing directory works with autocd set.
just skip the first argument and pass the rest as is. checking for directory breaks cd'ing to symlinked directories
tests are failing
|
would love to see this merge |
|
Would this work for zsh as well? |
I updated the initial comment with reproduction steps for bash. Checked in zsh and seems to work correctly already: % setopt autocd
% eval "$(zoxide init --cmd cd zsh)"
% / |
|
@ajeetdsouza Is there any update on this? Seems like a very useful feature to have! |
PR is ready to be merged, as far as I'm concerned. I've been using this fix for a few months now, everything seems to be ok. |
|
bump |
|
This seems like a neat improvement. @ajeetdsouza any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bash, when autocd option is set and user enters a directory name as a command, it results in a very specific call to cd:
cd -- [directory name]
zoxide's directory changing function passes all arguments to __zoxide_z as is, including the "--" first argument. By detecting this and skipping the first argument changing directory works with autocd set.
This particular bug only happens when initializing zoxide with
--cmd cd. Here's how it breaks in bash: