Optimized symlink to package matching #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgarlag
requested changes
Nov 24, 2017
src/ScriptSymlinker.php
Outdated
| @@ -26,12 +26,12 @@ public static function createSymlinks(Event $event) | |||
| $symlinks = static::getSymlinks($event); | |||
| $fs = new Filesystem(); | |||
|
|
|||
| foreach ($event->getComposer()->getRepositoryManager()->getLocalRepository()->getPackages() as $package) { | |||
| if (isset($symlinks[$package->getName()])) { | |||
| foreach ($symlinks as $packageName => $symlink) { | |||
There was a problem hiding this comment.
Please, rename $symlink to $symlinkDefinitions
|
Ok I changed the variable name |
ajgarlag
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looping through all packages to see if they have a matching symlink defined in extra I switched it around and search a package for each defined symlink. This improves the speed, especially when having a big dependency list. Your defined symlinks are likely less in numbers then your defined packages ;)