Skip to content

Commit

Permalink
Migrate from travis-ci to github actions
Browse files Browse the repository at this point in the history
  • Loading branch information
ajgarlag committed Dec 17, 2020
1 parent eb7882f commit d8887e7
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 38 deletions.
39 changes: 39 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: test

on:
push:
pull_request:
schedule:
- cron: '0 5 10 * *'

jobs:
test:
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
php: [ '7.3', '7.4', '8.0' ]
composer-flags: [ '', '--prefer-lowest' ]

steps:
- name: Install PHP
uses: shivammathur/setup-php@master
with:
php-version: ${{ matrix.php }}

- uses: actions/checkout@v2

- name: Conditional league/csv installation
if: ${{ matrix.php == '8.0' }}
run: composer remove --dev league/csv --no-update

- name: Validate composer.json and composer.lock
run: composer validate --ansi

- name: Install dependencies
if: steps.composer-cache.outputs.cache-hit != 'true'
run: composer update --ansi ${{ matrix.composer-flags }}

- name: Run test suite
run: composer run-script test --ansi
7 changes: 0 additions & 7 deletions .scrutinizer.yml

This file was deleted.

27 changes: 0 additions & 27 deletions .travis.yml

This file was deleted.

1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- Upgrade php-cs-fixer dependency and fix-cs
- Migrate code to PHP 7.3 adding scalar param type hints and return types
- Upgrade phpunit dependency and fix tests
- Migrate from travis-ci to github actions

## [0.3.0] - 2019-03-29
### Added
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@ AjglCsvRfc
The AjglCsvRfc component offers a drop in replacement for native PHP CSV related functions to read and/or write RFC4180
compliant CSV files.

[![Build Status](https://travis-ci.org/ajgarlag/AjglCsvRfc.png?branch=master)](https://travis-ci.org/ajgarlag/AjglCsvRfc)
[![Build Status](https://github.com/ajgarlag/AjglCsvRfc/workflows/test/badge.svg?branch=master)](https://github.com/ajgarlag/AjglCsvRfc/actions)
[![Latest Stable Version](https://poser.pugx.org/ajgl/csv-rfc/v/stable.png)](https://packagist.org/packages/ajgl/csv-rfc)
[![Latest Unstable Version](https://poser.pugx.org/ajgl/csv-rfc/v/unstable.png)](https://packagist.org/packages/ajgl/csv-rfc)
[![Total Downloads](https://poser.pugx.org/ajgl/csv-rfc/downloads.png)](https://packagist.org/packages/ajgl/csv-rfc)
[![Montly Downloads](https://poser.pugx.org/ajgl/csv-rfc/d/monthly.png)](https://packagist.org/packages/ajgl/csv-rfc)
[![Daily Downloads](https://poser.pugx.org/ajgl/csv-rfc/d/daily.png)](https://packagist.org/packages/ajgl/csv-rfc)
[![License](https://poser.pugx.org/ajgl/csv-rfc/license.png)](https://packagist.org/packages/ajgl/csv-rfc)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/ajgarlag/AjglCsvRfc/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/ajgarlag/AjglCsvRfc/?branch=master)
[![Code Coverage](https://scrutinizer-ci.com/g/ajgarlag/AjglCsvRfc/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/ajgarlag/AjglCsvRfc/?branch=master)
[![SensioLabsInsight](https://insight.sensiolabs.com/projects/7218debc-6c07-4a60-9b0b-e08103c1e0b2/mini.png)](https://insight.sensiolabs.com/projects/7218debc-6c07-4a60-9b0b-e08103c1e0b2)

The native PHP implementation contains a *Wont fix* bug [#50686] when you try to write a CSV field which contains the
Expand Down
2 changes: 1 addition & 1 deletion src/Spl/SplFileObjectTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ trait SplFileObjectTrait
{
abstract public function getCsvControl();

abstract public function fwrite($str, $length = null);
abstract public function fwrite(string $data, int $length = 0);

protected function fixCsvControl(): void
{
Expand Down

0 comments on commit d8887e7

Please sign in to comment.