Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit hook does not respect --from-ref / --to-ref #103

Closed
KangOl opened this issue Dec 3, 2020 · 1 comment · Fixed by #109
Closed

pre-commit hook does not respect --from-ref / --to-ref #103

KangOl opened this issue Dec 3, 2020 · 1 comment · Fixed by #109
Assignees
@akaihola
Labels
bug Something isn't working
Milestone
Darker 1.2.2

Comments

@KangOl
Copy link

KangOl commented Dec 3, 2020

When running darker through pre-commit, it ignores the --from-ref and --to-ref arguments.

These 2 commands should behave the same.

pre-commit run darker --from-ref HEAD~1 --to-ref HEAD
darker --revision HEAD~1..HEAD

The pre-commit arguments are exposed via the environment variables PRE_COMMIT_FROM_REF and PRE_COMMIT_TO_REF
@akaihola
Copy link
Owner

akaihola commented Dec 4, 2020

Thanks @KangOl for your bug report! We'll definitely fix this for the next release.

Heads up @sherbie @samoylovfp @Pacu2 @CorreyL

@akaihola akaihola added the bug Something isn't working label Dec 4, 2020
@akaihola akaihola added this to the 1.2.2 milestone Dec 4, 2020
akaihola added a commit that referenced this issue Dec 25, 2020
@akaihola
Get revrange from env vars with -r :PRE-COMMIT:
cb7a06f 
Fixes #103
@akaihola akaihola mentioned this issue Dec 25, 2020
Merged
@akaihola akaihola self-assigned this Dec 25, 2020
@akaihola akaihola linked a pull request Dec 25, 2020 that will close this issue
Get revision range from pre-commit environment variables #109
Merged
akaihola added a commit that referenced this issue Dec 26, 2020
@akaihola
Get revrange from env vars with -r :PRE-COMMIT:
de19598 
Fixes #103
akaihola added a commit that referenced this issue Dec 30, 2020
@akaihola
Get revrange from env vars with -r :PRE-COMMIT:
8cba9b7 
Fixes #103
@akaihola akaihola mentioned this issue Feb 21, 2021
Closed
@akaihola akaihola mentioned this issue Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akaihola akaihola

Labels
bug Something isn't working
Projects
None yet
Milestone
Darker 1.2.2
Development

Successfully merging a pull request may close this issue.

Get revision range from pre-commit environment variables akaihola/darker
2 participants
@akaihola @KangOl