Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --jobs support #178

Closed
overratedpro opened this issue Aug 12, 2021 · 3 comments · Fixed by #179
Closed

Missing --jobs support #178

overratedpro opened this issue Aug 12, 2021 · 3 comments · Fixed by #179
Labels
enhancement New feature or request
Milestone

Comments

@overratedpro
Copy link
Collaborator

Monitoring the resource consumption with multiple Python files staged in a pre-commit scenario, the CPU is not used very effectively, since only a single subprocess is invoked. There should be a way to parallelize the workload over separate files, utilizing all available CPU cores to achieve better performance.

@rogalski rogalski mentioned this issue Aug 18, 2021
9 tasks
@akaihola akaihola added the enhancement New feature or request label Aug 29, 2021
@akaihola akaihola added this to the 1.4.0 milestone Sep 4, 2021
@rogalski
Copy link
Contributor

Let's rename this issue into "missing --jobs support"

@rogalski
Copy link
Contributor

Please note that despite we initially suspected CPU bottleneck, the actual root cause is different, see #204 #205 #206

@akaihola akaihola changed the title performance with multiple files Missing --jobs support Sep 24, 2021
@akaihola
Copy link
Owner

If we manage to improve bisection performance and short-circuit bisection on Black failures, do you still see --jobs necessary? If so, can you live without it until a 1.4.0 release a few weeks later?

@akaihola akaihola modified the milestones: 1.4.0, 1.4.1, 1.4.2 Feb 8, 2022
@akaihola akaihola modified the milestones: 1.4.2, 1.5.0 Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants