Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --jobs to -W / --workers #352

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Rename --jobs to -W / --workers #352

merged 1 commit into from
Apr 6, 2022

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Apr 1, 2022 •
edited
Loading

Fixes #335.

The --jobs option was originally proposed in #178 and implemented in #179.

@akaihola akaihola added the enhancement New feature or request label Apr 1, 2022
@akaihola akaihola added this to the 1.5.0 milestone Apr 1, 2022
@akaihola akaihola requested a review from overratedpro April 1, 2022 19:39
@akaihola akaihola self-assigned this Apr 1, 2022
@akaihola
Copy link
Owner Author

akaihola commented Apr 1, 2022

@rogalski, would you like to review this option rename in Darker?

@akaihola akaihola force-pushed the workers-not-jobs-option branch from 3605ee9 to 4aa974d Compare April 5, 2022 16:10
@akaihola akaihola force-pushed the workers-not-jobs-option branch from 4aa974d to d4c39d7 Compare April 5, 2022 16:55
@akaihola akaihola added review needed Please volunteer for code review to speed up merging this pull request. Thank you! help wanted Extra attention is needed labels Apr 6, 2022
@akaihola
Copy link
Owner Author

akaihola commented Apr 6, 2022

@MatthijsBurgh & @roniemartinez: as the original authors of the --jobs feature seem to be busy and unable to review this, may I ask you whether you'd agree on changing the name of the option from --jobs to -W/--workers (similar to Black)? Are there some viewpoints which would support --jobs as a better name?

roniemartinez
roniemartinez approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@roniemartinez roniemartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaihola akaihola merged commit 262d028 into master Apr 6, 2022
@akaihola akaihola deleted the workers-not-jobs-option branch April 6, 2022 19:34
@akaihola
Copy link
Owner Author

akaihola commented Apr 6, 2022

Thanks @roniemartinez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roniemartinez roniemartinez roniemartinez approved these changes

@overratedpro overratedpro Awaiting requested review from overratedpro

@MatthijsBurgh MatthijsBurgh Awaiting requested review from MatthijsBurgh

Assignees

@akaihola akaihola

Labels
enhancement New feature or request help wanted Extra attention is needed review needed Please volunteer for code review to speed up merging this pull request. Thank you!
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 1.5.0
Development

Successfully merging this pull request may close these issues.

--jobs option name doesn't match the corresponding -W/--workers in Black
2 participants
@akaihola @roniemartinez