Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 1.2.1. Fixes #100. #101

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Release version 1.2.1. Fixes #100. #101

merged 1 commit into from
Dec 1, 2020

Conversation

akaihola
Copy link
Owner

Added

  • Travis CI now runs Pylint on modified lines via pytest-darker
  • Darker can now be used as a pre-commit hook (see pre-commit)
  • Document integration with Vim
  • Thank all contributors right in the README
  • RevisionRange class and Git repository test fixture improvements in preparation for a larger refactoring coming in Common ancestor fix #80

Fixed

  • Improve example in README and clarify that path argument can also be a directory

@akaihola akaihola added the release Preparing for a new release label Nov 30, 2020
@akaihola akaihola added this to the 1.2.1 milestone Nov 30, 2020
@akaihola akaihola self-assigned this Nov 30, 2020
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 30, 2020

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 5.00 ⭐ 5.00 ⭐ 0.00
Working memory 2.00 ⭐ 2.00 ⭐ 0.00
Quality 100.00% 100.00% 0.00%
Other metrics Before After Change
Lines 3 3 0
Changed files Quality Before Quality After Quality Change
src/darker/version.py 100.00% ⭐ 100.00% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Copy link
Collaborator

@sherbie sherbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to ship 👍

@akaihola akaihola merged commit e40ae13 into master Dec 1, 2020
@akaihola akaihola deleted the release-1.2.1 branch December 1, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Preparing for a new release
Projects
Development

Successfully merging this pull request may close these issues.

3 participants