Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read README.rst excplicitly as UTF-8 in setup.py to fix Windows installation problems #123

Merged
merged 2 commits into from
Apr 24, 2021

Conversation

akaihola
Copy link
Owner

No description provided.

This should fix a failing `pip install` on Windows. Fixes #121.
@akaihola akaihola added the bug Something isn't working label Apr 22, 2021
@akaihola akaihola added this to the 1.2.3 milestone Apr 22, 2021
@akaihola akaihola self-assigned this Apr 22, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 22, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.26%.

Quality metrics Before After Change
Complexity 0.78 ⭐ 0.78 ⭐ 0.00
Method Length 19.00 ⭐ 19.67 ⭐ 0.67 👎
Working memory 6.22 🙂 6.22 🙂 0.00
Quality 87.08% 86.82% -0.26% 👎
Other metrics Before After Change
Lines 31 31 0
Changed files Quality Before Quality After Quality Change
setup.py 87.08% ⭐ 86.82% ⭐ -0.26% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@akaihola akaihola linked an issue Apr 22, 2021 that may be closed by this pull request
@akaihola
Copy link
Owner Author

@martinRenou I invited you as a collaborator on this repository. If you accept, I can assign you as a reviewer for this pull request.

@martinRenou
Copy link
Collaborator

Sure! Thanks. I'll give your change a try on the Windows CI tests.

Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This seems to correctly fix the Windows issue

@martinRenou martinRenou mentioned this pull request Apr 23, 2021
@akaihola akaihola merged commit 24f1b10 into master Apr 24, 2021
@akaihola akaihola deleted the readme-encoding branch April 24, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Installation issue on Windows
2 participants