Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 1.2.4 #144

Closed
wants to merge 0 commits into from
Closed

Release version 1.2.4 #144

wants to merge 0 commits into from

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented May 25, 2021

Closes #143.

Remaining pull requests to merge for this release:

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 27, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.73 ⭐ 2.73 ⭐ 0.00
Method Length 59.69 ⭐ 59.69 ⭐ 0.00
Working memory 6.71 🙂 6.71 🙂 0.00
Quality 76.63% 76.63% 0.00%
Other metrics Before After Change
Lines 4182 4182 0
Changed files Quality Before Quality After Quality Change
setup.py 89.33% ⭐ 89.33% ⭐ 0.00%
src/darker/init.py % % %
src/darker/main.py 40.73% 😞 40.73% 😞 0.00%
src/darker/argparse_helpers.py 84.23% ⭐ 84.23% ⭐ 0.00%
src/darker/black_diff.py 79.91% ⭐ 79.91% ⭐ 0.00%
src/darker/chooser.py 75.85% ⭐ 75.85% ⭐ 0.00%
src/darker/command_line.py 73.52% 🙂 73.52% 🙂 0.00%
src/darker/config.py 88.87% ⭐ 88.87% ⭐ 0.00%
src/darker/diff.py 79.80% ⭐ 79.80% ⭐ 0.00%
src/darker/git.py 75.17% ⭐ 75.17% ⭐ 0.00%
src/darker/help.py 76.92% ⭐ 76.92% ⭐ 0.00%
src/darker/import_sorting.py 86.68% ⭐ 86.68% ⭐ 0.00%
src/darker/linting.py 69.24% 🙂 69.24% 🙂 0.00%
src/darker/utils.py 85.60% ⭐ 85.60% ⭐ 0.00%
src/darker/verification.py 93.74% ⭐ 93.74% ⭐ 0.00%
src/darker/version.py 100.00% ⭐ 100.00% ⭐ 0.00%
src/darker/tests/init.py % % %
src/darker/tests/conftest.py 86.19% ⭐ 86.19% ⭐ 0.00%
src/darker/tests/git_diff_example_output.py 99.50% ⭐ 99.50% ⭐ 0.00%
src/darker/tests/helpers.py 88.66% ⭐ 88.66% ⭐ 0.00%
src/darker/tests/test_argparse_helpers.py 80.81% ⭐ 80.81% ⭐ 0.00%
src/darker/tests/test_black_diff.py 80.69% ⭐ 80.69% ⭐ 0.00%
src/darker/tests/test_chooser.py 83.50% ⭐ 83.50% ⭐ 0.00%
src/darker/tests/test_command_line.py 72.74% 🙂 72.74% 🙂 0.00%
src/darker/tests/test_config.py 73.14% 🙂 73.14% 🙂 0.00%
src/darker/tests/test_diff.py 85.97% ⭐ 85.97% ⭐ 0.00%
src/darker/tests/test_difflib.py 95.36% ⭐ 95.36% ⭐ 0.00%
src/darker/tests/test_git.py 78.48% ⭐ 78.48% ⭐ 0.00%
src/darker/tests/test_import_sorting.py 86.36% ⭐ 86.36% ⭐ 0.00%
src/darker/tests/test_linting.py 75.08% ⭐ 75.08% ⭐ 0.00%
src/darker/tests/test_main.py 73.03% 🙂 73.03% 🙂 0.00%
src/darker/tests/test_main_revision.py 57.09% 🙂 57.09% 🙂 0.00%
src/darker/tests/test_utils.py 86.68% ⭐ 86.68% ⭐ 0.00%
src/darker/tests/test_verification.py 87.42% ⭐ 87.42% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/darker/main.py format_edited_parts 21 😞 243 ⛔ 15 😞 29.17% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/darker/main.py main 19 😞 262 ⛔ 11 😞 35.62% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_main.py test_main 0 ⭐ 257 ⛔ 17 ⛔ 44.95% 😞 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_command_line.py test_parse_command_line 4 ⭐ 469 ⛔ 8 🙂 50.69% 🙂 Try splitting into smaller methods
src/darker/tests/test_main_revision.py test_revision 1 ⭐ 236 ⛔ 9 🙂 57.09% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Preparing for a new release
Projects
Development

Successfully merging this pull request may close these issues.

Release version 1.2.4
1 participant