ASTVerifier #214
Merged
ASTVerifier #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaihola
reviewed
Oct 4, 2021
akaihola
reviewed
Oct 4, 2021
akaihola
reviewed
Oct 4, 2021
akaihola
reviewed
Oct 4, 2021
akaihola
requested changes
Oct 4, 2021
|
Docstring fixes are pushed. Comment about API deprecation vs. just removing code still stands. About lru_cache - I decided to keep implementation as it is. Seems good enough to me. We are close to getting that ready. Let's make sure we are on the same page regarding next steps. |
|
I'm rebasing this on previous merges and force-pushing the branch into your fork (which is something GitHub seems to allow!). I'd like to have |
Improved performance by caching intermediate data during bisect.
|
I think this is now in a state ready for merging (provided that the tests pass, we'll see in a minute). |
akaihola
approved these changes
Oct 22, 2021
This was referenced Oct 31, 2021
This was
linked to
issues
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved performance by caching intermediate data during bisect.
Major changes:
Closes #211