Linenum diffing refactor #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty list of opcodes now results in an empty list of edited line numbers.
`darker.git.EditedLinenumsDiffer` now handles - retrieving HEAD version of a file - comparing to a version of the file given as a string - converting the resulting opcodes into a list of changed line numbers - extending changed chunks with a given number of context lines
Merged
samoylovfp
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the algorithm for finding the list of line numbers of modified lines. Moving it into a new
EditedLinenumsDifferclass indarker.git. This is also in preparation for adding possible support for linters (like Mypy and Pylint).