NixOS build failed when pytest-darker called pylint
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaihola
force-pushed
the
fix-nixos-build
branch
from
ef18649 to
a1c7783
Compare
|
NixOS tests keep failing. I rebased this branch on top of |
|
Ha! Activating the virtualenv seems to fix this, at least on ubuntu-latest. But how did it ever succeed earlier without doing that?!? |
|
GitHub really makes us wait for macos workflows. I'm just not going to care about those now. |
Maybe paths for binaries aren't always correct otherwise?
akaihola
force-pushed
the
fix-nixos-build
branch
from
f9aaed0 to
de41d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened first in the ubuntu-latest and macos-latest NixOS builds for #300. And it wasn't a transient problem, since they failed again (see build #860 for ubuntu-latest and macos-latest.
But for this PR, strangely, the ubuntu-latest nixos build succeeds. It's hard for me to believe that the code changes in #300 would have caused the failure.
I'll still use this PR to find a fix..