Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated README for issue#294 #325

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Updated README for issue#294 #325

merged 3 commits into from
Apr 5, 2022

Conversation

dhrvjha
Copy link
Contributor

@dhrvjha dhrvjha commented Mar 7, 2022

Added link to original article and quoted the original text from the article
Fixes #294

@dhrvjha dhrvjha changed the title Refactoring a single commit vs entire document. Updated README for issue#294 Mar 7, 2022
akaihola
akaihola reviewed Mar 9, 2022
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@dhrvjha dhrvjha closed this Mar 27, 2022
@akaihola
Copy link
Owner

Hi @dhrvjha,
I'd still like to return to this pull request a bit later, complete it and get it merged. Do you mind if I reopen it and return to it after I've dealt with a couple of other PRs first?

@akaihola
Copy link
Owner

Reopening, I have some changes to push.

@akaihola akaihola reopened this Mar 30, 2022
@akaihola akaihola force-pushed the why-darker-readme branch from 8463f5c to fe3300e Compare March 30, 2022 20:19
@akaihola akaihola self-assigned this Mar 30, 2022
@akaihola akaihola added the documentation Improvements or additions to documentation label Mar 30, 2022
@akaihola akaihola added this to the 1.5.0 milestone Mar 30, 2022
@akaihola
Copy link
Owner

@dhrvjha, @ambv, or @jack1142, could you review my changes to the README additions?

@Jackenmen
Copy link

Hmm, it might get a bit long but personally I feel like it's important to mention that you can avoid reformat commit showing in git blame by using ignore revs file (which GitHub now supports btw) which is explained more comprehensively here:
https://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html

@dhrvjha
Copy link
Contributor Author

dhrvjha commented Mar 31, 2022

I am sorry I thought it was way behind and may be better to start with a latest branch, I don't have any problem.

@akaihola
Copy link
Owner

@jack1142, thanks for the idea, I added a mention of ignoreRevsFile and linked to Git documentation.

@akaihola akaihola force-pushed the why-darker-readme branch 2 times, most recently from 3aaf6af to 7471e8a Compare April 1, 2022 19:41
@akaihola akaihola force-pushed the why-darker-readme branch from 7471e8a to d67e029 Compare April 5, 2022 16:11
@akaihola akaihola merged commit 0446a91 into akaihola:master Apr 5, 2022
@dhrvjha dhrvjha deleted the why-darker-readme branch April 5, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaihola akaihola akaihola left review comments

Assignees

@akaihola akaihola

Labels
documentation Improvements or additions to documentation
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 1.5.0
Development

Successfully merging this pull request may close these issues.

README doesn't mention critique against using Darker
3 participants
@dhrvjha @akaihola @Jackenmen