Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #415

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Add support for Python 3.11 #415

merged 3 commits into from
Dec 26, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 17, 2022

Python 3.11 was released on 2022-10-24 🚀

image

Also test Python 3.12-dev.

@akaihola akaihola added this to the 1.6.0 milestone Dec 19, 2022
@akaihola akaihola added the enhancement New feature or request label Dec 19, 2022
@akaihola
Copy link
Owner

You shouldn't directly update CONTRIBUTORS.rst. Instead, modify contributors.yaml and run the script

python release_tools/update_contributors.py generate --token=ghp_<your GitHub API token> -r -c

I'll need to document this and add a comment in generated content (CONTRIBUTORS.rst and inside README.rst).

@hugovk
Copy link
Contributor Author

hugovk commented Dec 19, 2022

Ah, thanks. Yes, CONTRIBUTING.rst says "add your information in CONTRIBUTORS.rst", so good idea to update that, although requiring to create an API token is a bit offputting and might deter some contributors.

I guess contributors can just update contributors.yaml and you can run the script later (or automate it :)

@@ -88,13 +88,15 @@ jobs:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
- '3.12-dev'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if using a development version of Python will lead to frequent test failures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are possible but hopefully not frequent. I've rarely seen them when testing dev versions, but I have found a release blocker in CPython itself by doing so :)

This may also help find early issues in Black and isort, and other linters.

It also means Darker can be ready for 3.12 sooner.

If there are failures, and they're not quick to fix, I wouldn't hesitate to comment this out until it's resolved.

I guess as the linters used by Darker do AST things, there's more exposure to syntax changes before the beta feature freeze in May, so one approach could be to wait until then.

CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Owner

@akaihola akaihola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, almost ready to merge.

@akaihola akaihola merged commit 4785ed1 into akaihola:master Dec 26, 2022
@akaihola
Copy link
Owner

Thanks @hugovk!

@hugovk hugovk deleted the add-3.11 branch December 26, 2022 16:58
@hugovk
Copy link
Contributor Author

hugovk commented Dec 26, 2022

You're welcome, and thank you for Darker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants