-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 #415
Conversation
You shouldn't directly update
I'll need to document this and add a comment in generated content ( |
Ah, thanks. Yes, I guess contributors can just update |
@@ -88,13 +88,15 @@ jobs: | |||
- '3.8' | |||
- '3.9' | |||
- '3.10' | |||
- '3.11' | |||
- '3.12-dev' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if using a development version of Python will lead to frequent test failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failures are possible but hopefully not frequent. I've rarely seen them when testing dev versions, but I have found a release blocker in CPython itself by doing so :)
This may also help find early issues in Black and isort, and other linters.
It also means Darker can be ready for 3.12 sooner.
If there are failures, and they're not quick to fix, I wouldn't hesitate to comment this out until it's resolved.
I guess as the linters used by Darker do AST things, there's more exposure to syntax changes before the beta feature freeze in May, so one approach could be to wait until then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments, almost ready to merge.
Thanks @hugovk! |
You're welcome, and thank you for Darker! |
Python 3.11 was released on 2022-10-24 🚀
Also test Python 3.12-dev.