Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix baseline linting to support cov_to_lint.py again #445

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Fix baseline linting to support cov_to_lint.py again #445

merged 3 commits into from
Jan 16, 2023

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Jan 4, 2023 •
edited
Loading

@akaihola akaihola added the bug Something isn't working label Jan 4, 2023
@akaihola akaihola added this to the 1.7.0 milestone Jan 4, 2023
@akaihola akaihola self-assigned this Jan 4, 2023
@akaihola akaihola mentioned this pull request Jan 4, 2023
Merged
3 tasks
@akaihola akaihola marked this pull request as draft January 6, 2023 22:46
@akaihola akaihola force-pushed the fix-cov_to_lint branch 14 times, most recently from c60d06a to d60d717 Compare January 14, 2023 09:48
@akaihola akaihola marked this pull request as ready for review January 14, 2023 10:07
@akaihola
Pass required information to cov_to_lint.py
be037eb 
Now that we run linters for a baseline on `rev1` in a temporary clone
of the repository, `cov_to_lint.py` needs to find the pre-generated
coverage files. For that, we pass the original repository root path and
the revision being linted as environment variables.
@akaihola
Normalize whitespace to support cov_to_lint.py
d661bd2 
Indentation simplification would prevent matching `cov_to_lint` output
from different commits.
@akaihola akaihola merged commit b8beb2c into master Jan 16, 2023
@akaihola akaihola deleted the fix-cov_to_lint branch January 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akaihola akaihola

Labels
bug Something isn't working
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 1.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@akaihola