Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local action outside of this repo #486

Merged
merged 3 commits into from
May 1, 2023
Merged

Fix local action outside of this repo #486

merged 3 commits into from
May 1, 2023

Conversation

MatthijsBurgh
Copy link
Collaborator

@MatthijsBurgh MatthijsBurgh commented Mar 27, 2023

Fixes #489 and #485.

@MatthijsBurgh MatthijsBurgh requested a review from akaihola March 27, 2023 11:47
@akaihola
Copy link
Owner

akaihola commented Apr 1, 2023

Hi @MatthijsBurgh, thanks for the patch, and sorry for missing the side effect of my "improvement".

The problem I was solving was to make sure latest changes to the commit-range action are always used. If we specify the version, we can only use commit-range from past releases of Darker. I wonder what would be a proper way to use commit-range from the checkout itself, but only for Darker's own builds.

Could you rebase this PR now that I merged your milestone name fix?

@akaihola akaihola added bug Something isn't working CI labels Apr 1, 2023
@akaihola akaihola added this to the Darker 1.7.2 milestone Apr 1, 2023
@MatthijsBurgh
Copy link
Collaborator Author

@akaihola Yes, I fugured out you tried to achieve that. I have to look into it again to see whether there is another solution to it.

@MatthijsBurgh
Copy link
Collaborator Author

@akaihola I just have been busy finishing my thesis and now I am on RoboCup event in Portugal.

@akaihola akaihola merged commit 2a55e6f into master May 1, 2023
@akaihola akaihola deleted the fix/action branch May 1, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
Development

Successfully merging this pull request may close these issues.

[Darker Action] 1.7.1 is broken due to actions/commit-range
3 participants