Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.12 compatibility of the GitHub Action #497

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented May 30, 2023

Partially fixes #495.

pkg_resources is no longer available by default in the environment since setuptools was dropped in Python 3.12. Instead of installing one of those, we're now using pip-requirements-parser as a more stable solution since pkg_resources is deprecated in favor of importlib which doesn't provide tooling for parsing requirements.

@akaihola akaihola added the bug Something isn't working label May 30, 2023
@akaihola akaihola added this to the Darker 1.7.2 milestone May 30, 2023
@akaihola akaihola requested a review from my-tien May 30, 2023 06:15
@akaihola akaihola self-assigned this May 30, 2023
@akaihola akaihola force-pushed the parse_requirements branch 2 times, most recently from 6f699f1 to b50f6fb Compare May 30, 2023 21:00
akaihola added 3 commits May 31, 2023 10:53
`pkg_resources` is no longer available by default in the environment
since `setuptools` was dropped in Python 3.12. Instead of installing one
of those, we're now using a more stable solution since `pkg_resources`
is deprecated in favor of `importlib` which doesn't provide tooling for
parsing requirements.
@akaihola akaihola force-pushed the parse_requirements branch from b50f6fb to eba83ec Compare May 31, 2023 07:54
action.yml Show resolved Hide resolved
@akaihola
Copy link
Owner Author

akaihola commented May 31, 2023

@my-tien all checks pass in this PR. Could you review? This then opens the road for #494.

@akaihola akaihola merged commit 5dfb1b7 into master Jun 5, 2023
@akaihola akaihola deleted the parse_requirements branch June 5, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Multiple breakages with Python 3.12.dev
2 participants