Format with Black 2024 #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaihola
reviewed
Feb 29, 2024
There was a problem hiding this comment.
So far I've intentionally not blackened the whole code base of Darker, but instead used Darker itself to gradually update formatting to newest Black rules whenever a section of code is touched for some other reason in a PR.
This neatly results in Darker "eating its own dogfood", and acts as occasional real-life tests for Darker itself.
Opinions about this approach?
|
Yes, that sounds reasonable, feel free to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #540, apply Black's new style changes in a dedicated PR.