Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated options in [tool.darker] #607

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Aug 1, 2024

These options were deprecated in Darker 2.1.1 (see #578). They can still be used as command line arguments or in the [tool.black] section of the configuration file.

  • remove the options from DarkerConfig
  • resurrect tests but modify them to assert that the options are ignored in [tool.darker] (or cause an error)

See also:

🟠 Pending review is delaying Darker 3.0.0 release.

@akaihola akaihola added the enhancement New feature or request label Aug 1, 2024
@akaihola akaihola self-assigned this Aug 1, 2024
@akaihola akaihola requested a review from Svenito August 1, 2024 14:57
@akaihola akaihola force-pushed the remove-config-deprecations branch from 1be745a to 42f485d Compare August 1, 2024 14:58
@akaihola akaihola force-pushed the remove-config-deprecations branch 2 times, most recently from 1bed74c to c0dbce2 Compare August 9, 2024 06:07
@akaihola akaihola marked this pull request as draft August 9, 2024 06:13
@akaihola akaihola marked this pull request as ready for review August 9, 2024 06:50
@akaihola akaihola force-pushed the remove-config-deprecations branch from c0dbce2 to 5c8aef7 Compare August 25, 2024 19:13
@akaihola akaihola requested a review from Garfounkel August 27, 2024 15:55
@akaihola akaihola force-pushed the remove-config-deprecations branch 2 times, most recently from e654bda to e6a163c Compare August 27, 2024 20:52
@akaihola akaihola requested a review from dwt September 15, 2024 14:42
@akaihola
Copy link
Owner Author

@CorreyL contributed --skip-string-normalization in #3.

@hauntsaninja originally requested the --skip-magic-trailing-comma option in #152, and @talhajunaidd implemented it in #153.

Both of those are still there as a command line option, but not supported in pyproject.toml's [tool.darker] section any more. Put them in [tool.black] instead.

@dwt noted in #502 that hyphenated spellings of configuration options like skip-magic-trailing-comma = and skip-string-normalization = used to be ignored by Darker in pyproject.toml. Those two are not a concern of Darker's any more.

Would any of you guys be willing to take another look at this PR to complete its review?

@akaihola akaihola requested a review from CorreyL September 15, 2024 14:54
Copy link
Collaborator

@dwt dwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would like the information about where the options move to to be include din the deprecation warnings to spare the user a research step and give him the solution immediately.

src/darker/tests/test_command_line.py Show resolved Hide resolved
src/darker/tests/test_command_line.py Show resolved Hide resolved
src/darker/tests/test_command_line.py Show resolved Hide resolved
@akaihola akaihola force-pushed the remove-config-deprecations branch 4 times, most recently from 4cfee7a to 31f5b32 Compare September 24, 2024 19:16
@akaihola akaihola force-pushed the remove-config-deprecations branch 2 times, most recently from 1ded5cf to 83f9c2a Compare September 25, 2024 15:53
@akaihola akaihola force-pushed the remove-config-deprecations branch 2 times, most recently from c595c97 to de72536 Compare September 25, 2024 16:34
@akaihola akaihola force-pushed the remove-config-deprecations branch from de72536 to db99c7e Compare September 25, 2024 16:37
@akaihola akaihola merged commit e854b74 into master Sep 25, 2024
37 checks passed
@akaihola akaihola deleted the remove-config-deprecations branch September 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants