-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated options in [tool.darker]
#607
Conversation
1be745a
to
42f485d
Compare
1bed74c
to
c0dbce2
Compare
c0dbce2
to
5c8aef7
Compare
e654bda
to
e6a163c
Compare
@CorreyL contributed @hauntsaninja originally requested the Both of those are still there as a command line option, but not supported in @dwt noted in #502 that hyphenated spellings of configuration options like Would any of you guys be willing to take another look at this PR to complete its review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would like the information about where the options move to to be include din the deprecation warnings to spare the user a research step and give him the solution immediately.
4cfee7a
to
31f5b32
Compare
1ded5cf
to
83f9c2a
Compare
c595c97
to
de72536
Compare
de72536
to
db99c7e
Compare
These options were deprecated in Darker 2.1.1 (see #578). They can still be used as command line arguments or in the
[tool.black]
section of the configuration file.DarkerConfig
[tool.darker]
(or cause an error)See also:
--no-skip-string-normalization
option #50--skip-magic-trailing-comma
flag #152pyproject.toml
options with hyphens are ignored #502🟠 Pending review is delaying Darker 3.0.0 release.