-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up parameterized tests which use Git #761
Conversation
85d9279
to
f49c0dc
Compare
50388df
to
2211f88
Compare
e6e4ade
to
9db0a6a
Compare
This is done by using the new module-scoped Git repository fixture from Darkgraylib.
9db0a6a
to
4d7f7c2
Compare
…est_edited_linenums_differ_revision_vs_lines`
4d7f7c2
to
91742fb
Compare
Hi @DeinAlptraum & @clintonsteiner, Happy New Year! Are you interested to review how the speed of Darker unit tests on Windows almost doubled? The amount of changes is quite large, and unfortunately the readability of tests suffered a bit (in my opinion), but now it's making way fewer Git subprocess calls (which are very expensive on Windows). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy new year!
LGTM, but can't guarantee I didn't miss anything among the large number of changes
This is done by using the new module-scoped Git repository fixture from Darkgraylib.
To get aggregate timings for parameterized tests:
analyze_pytest_log.py