Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use as a pre-commit hook #91

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Add ability to use as a pre-commit hook #91

merged 3 commits into from
Nov 30, 2020

Conversation

akaihola
Copy link
Owner

This is #2 rebased on top of master as of 2020-11-26.

@akaihola akaihola added the enhancement New feature or request label Nov 27, 2020
@akaihola akaihola added this to the 1.2.1 milestone Nov 27, 2020
@akaihola akaihola requested a review from samoylovfp November 27, 2020 11:14
@akaihola akaihola self-assigned this Nov 27, 2020
@akaihola akaihola mentioned this pull request Nov 27, 2020
Closed
@akaihola
Copy link
Owner Author

@Pacu2 and @CorreyL, I wonder if this now works correctly for you too? There was a lot of discussion in #91, does the rebase solve issues mentioned there?

@akaihola akaihola requested a review from CorreyL November 27, 2020 11:20
@Pacu2
Copy link
Contributor

Pacu2 commented Nov 27, 2020

@akaihola I'll check it out in the evening and let you know.

@sherbie
Copy link
Collaborator

sherbie commented Nov 30, 2020

This works nicely in a py38 setup.

@sherbie sherbie self-requested a review November 30, 2020 11:06
sherbie
sherbie reviewed Nov 30, 2020
View reviewed changes
.pre-commit-hooks.yaml Outdated Show resolved Hide resolved
@akaihola akaihola merged commit 9e37e28 into master Nov 30, 2020
@akaihola akaihola deleted the pre-commit-hook branch November 30, 2020 14:30
@akaihola akaihola mentioned this pull request Nov 30, 2020
Closed
8 tasks
@akaihola akaihola mentioned this pull request Sep 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherbie sherbie sherbie approved these changes

@Pacu2 Pacu2 Pacu2 approved these changes

@samoylovfp samoylovfp Awaiting requested review from samoylovfp

@CorreyL CorreyL Awaiting requested review from CorreyL

Assignees

@akaihola akaihola

Labels
enhancement New feature or request
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@akaihola @Pacu2 @sherbie