Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #97

Merged
merged 4 commits into from
Apr 25, 2021
Merged

Increase test coverage #97

merged 4 commits into from
Apr 25, 2021

Conversation

akaihola
Copy link
Owner

No description provided.

@akaihola akaihola added the CI label Nov 28, 2020
@akaihola akaihola added this to the 1.3.0 milestone Nov 28, 2020
@akaihola akaihola self-assigned this Nov 28, 2020
@akaihola akaihola marked this pull request as draft November 28, 2020 18:54
@akaihola akaihola force-pushed the increase-test-coverage branch 4 times, most recently from e2cfec5 to a42a7c2 Compare December 25, 2020 17:53
@akaihola akaihola modified the milestones: 1.3.0, 1.2.3 Dec 25, 2020
@akaihola akaihola force-pushed the increase-test-coverage branch 2 times, most recently from 7948518 to 275493e Compare January 1, 2021 14:06
@akaihola akaihola force-pushed the increase-test-coverage branch from 275493e to 598e471 Compare April 4, 2021 16:05
@akaihola akaihola force-pushed the increase-test-coverage branch from 598e471 to ec5487d Compare April 25, 2021 17:02
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 25, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.01%.

Quality metrics Before After Change
Complexity 0.63 ⭐ 0.67 ⭐ 0.04 👎
Method Length 58.45 ⭐ 56.76 ⭐ -1.69 👍
Working memory 13.42 😞 12.96 😞 -0.46 👍
Quality 68.70% 🙂 69.71% 🙂 1.01% 👍
Other metrics Before After Change
Lines 703 806 103
Changed files Quality Before Quality After Quality Change
src/darker/tests/conftest.py 83.94% ⭐ 83.92% ⭐ -0.02% 👎
src/darker/tests/helpers.py 87.80% ⭐ 84.61% ⭐ -3.19% 👎
src/darker/tests/test_git.py 64.21% 🙂 64.46% 🙂 0.25% 👍
src/darker/tests/test_linting.py 53.83% 🙂 60.03% 🙂 6.20% 👍
src/darker/tests/test_main.py 65.22% 🙂 65.33% 🙂 0.11% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/darker/tests/test_main.py test_main 0 ⭐ 195 😞 28 ⛔ 43.59% 😞 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_git.py test_git_get_modified_files 4 ⭐ 169 😞 17 ⛔ 47.06% 😞 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_linting.py test_run_linter 0 ⭐ 147 😞 29 ⛔ 47.87% 😞 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_main.py test_format_edited_parts 0 ⭐ 141 😞 21 ⛔ 51.04% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_git.py test_git_get_modified_files_revision_range 0 ⭐ 113 🙂 32 ⛔ 51.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@akaihola akaihola marked this pull request as ready for review April 25, 2021 17:03
@akaihola akaihola merged commit b11d74c into master Apr 25, 2021
@akaihola akaihola deleted the increase-test-coverage branch April 25, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant