Merge pull request #88 from akaihola/pylint-3.3.0

Update to Pylint 3.3.0+

.github/workflows/pylint.yml

@@ -15,7 +15,7 @@ jobs:
           pip install -U \
             defusedxml \
             pygments \
-            "pylint<3.3.0" \
+            "pylint>=3.3.0" \
             "pytest>=6.2.0" \
             requests \
             requests-cache \

CHANGES.rst

@@ -5,6 +5,7 @@ These features will be included in the next release:
 
 Added
 -----
+- Update to Pylint 3.3.0+ and adjust disabled messages accordingly.
 
 Removed
 -------

setup.cfg

@@ -62,7 +62,7 @@ test =
     mypy
     Pygments>=2.4.0
     pydocstyle
-    pylint<3.3.0
+    pylint>=3.3.0
     pytest>=6.2.0
     pytest-kwparametrize>=0.0.3
     requests_cache>=0.7

src/darkgraylib/argparse_helpers.py

@@ -194,7 +194,8 @@ def generate_options_for_readme(parser: ArgumentParser) -> str:
 class LogLevelAction(Action):  # pylint: disable=too-few-public-methods
     """Support for command line actions which increment/decrement the log level"""
 
-    def __init__(  # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
+    def __init__(
         self,
         option_strings: List[str],
         dest: str,

src/darkgraylib/tests/test_command_line.py

@@ -1,5 +1,8 @@
 """Unit tests for `darkgraylib.command_line` and `darkgraylib.main`."""
 
+# pylint: disable=too-many-arguments,too-many-positional-arguments,too-many-locals
+# pylint: disable=use-dict-literal
+
 import os
 from pathlib import Path
 from unittest.mock import Mock, patch
@@ -350,7 +353,7 @@ def test_parse_command_line(
 def test_parse_command_line_load_config_hook_called(tmp_path, monkeypatch):
     """The load configuration hook is called correctly."""
     monkeypatch.chdir(tmp_path)
-    with Path("pyproject.toml").open("w") as pyproject:
+    with Path("pyproject.toml").open("w", encoding="utf-8") as pyproject:
         toml.dump({"tool": {"darkgraylib": {"revision": "main"}}}, pyproject)
     hook_mock = Mock()
 

src/darkgraylib/tests/test_config.py

@@ -1,5 +1,7 @@
 """Tests for `darkgraylib.config`"""
 
+# pylint: disable=too-many-arguments,too-many-positional-arguments,use-dict-literal
+
 import os
 import re
 from argparse import ArgumentParser, Namespace
@@ -62,7 +64,7 @@ class OriginTrackingConfig(BaseConfig):
 
 
 @pytest.mark.kwparametrize(
-    dict(),  # pylint: disable=use-dict-literal
+    dict(),
     dict(cwd="lvl1"),
     dict(cwd="lvl1/lvl2"),
     dict(cwd="has_git", expect={}),
@@ -352,7 +354,7 @@ class OriginTrackingConfig(BaseConfig):
     confpath=None,
     expect={"config": "no_pyp"},
 )
-def test_load_config_path(  # pylint: disable=too-many-arguments
+def test_load_config_path(
     tmp_path, monkeypatch, srcs, cwd, confpath, expect
 ):
     """``load_config()`` finds and loads configuration based on source file paths"""

src/darkgraylib/tests/test_diff.py

@@ -1,5 +1,7 @@
 """Unit tests for `darkgraylib.diff`"""
 
+# pylint: disable=use-dict-literal
+
 import pytest
 
 from darkgraylib.diff import diff_and_get_opcodes, map_unmodified_lines

src/darkgraylib/tests/test_files.py

@@ -1,5 +1,7 @@
 """Tests for the `darkgraylib.files` module."""
 
+# pylint: disable=redefined-outer-name
+
 import os
 from contextlib import contextmanager
 from pathlib import Path

src/darkgraylib/tests/test_git.py

@@ -3,6 +3,7 @@
 # pylint: disable=no-member  # context managers misfire Pylint's member-checking
 # pylint: disable=redefined-outer-name  # fixtures misfire Pylint's redefinition checks
 # pylint: disable=use-dict-literal  # dict() ok with kwparametrize
+# pylint: disable=too-many-arguments,too-many-positional-arguments
 
 import os
 import re

src/darkgraylib/tests/test_highlighting.py

@@ -1,7 +1,7 @@
 """Unit tests for :mod:`darkgraylib.highlighting`"""
 
-# pylint: disable=too-many-arguments,redefined-outer-name,unused-argument
-# pylint: disable=protected-access
+# pylint: disable=protected-access,redefined-outer-name
+# pylint: disable=too-many-arguments,too-many-positional-arguments,unused-argument
 
 import os
 import sys

src/darkgraylib/tests/test_main.py

@@ -1,5 +1,7 @@
 """Unit tests for the `darkgraylib.main` module."""
 
+# pylint: disable=too-many-arguments,too-many-positional-arguments,use-dict-literal
+
 import sys
 from pathlib import Path
 

src/darkgraylib/tests/test_utils.py

@@ -1,5 +1,7 @@
 """Unit tests for `darkgraylib.utils`."""
 
+# pylint: disable=redefined-outer-name,use-dict-literal
+
 import os
 from pathlib import Path
 
@@ -25,6 +27,7 @@ def textdocument_factory(request):
     which it creates a temporary file) and the ``TextDocument.from_bytes()``
     classmethods.
     """
+    # pylint: disable=comparison-with-callable
     if request.param == TextDocument.from_file:
 
         def factory(content):

src/darkgraylib/utils.py

@@ -28,7 +28,8 @@ class TextDocument:
     DEFAULT_ENCODING = "utf-8"
     DEFAULT_NEWLINE = "\n"
 
-    def __init__(  # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
+    def __init__(
         self,
         string: str = None,
         lines: Iterable[str] = None,