chore: Pin slf4j-api to 1.7 to avoid downstream problems with Akka #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Mar 22, 2024
| "com.typesafe.slick" %% "slick" % SlickVersion, | ||
| // Slick 3.5 pulls in slf4j-api 2.2 which doesn't work with Akka | ||
| ("com.typesafe.slick" %% "slick" % SlickVersion).exclude("org.slf4j", "slf4j-api"), | ||
| "org.slf4j" % "slf4j-api" % "1.7.36", |
There was a problem hiding this comment.
do we need to add the explicit version here? with the exclude in place, I thought it would use what we have defined in upstream Akka dependencies
would be easy to forget this one once we bump slf4j in Akka
There was a problem hiding this comment.
I was thinking that since we remove the transitive one, we need to make sure there is another one pulled in or else you could end up with a classdef not found in some scenario, users will most likely have the akka-slf4j in there but maybe not always?
There was a problem hiding this comment.
ok, true, if not using Akka Typed
I'll add a note in the slf4j update ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #816