Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually expose ability to set rebalance listener #421

Closed
ktoso opened this issue Apr 3, 2018 · 1 comment
Closed

Actually expose ability to set rebalance listener #421

ktoso opened this issue Apr 3, 2018 · 1 comment
Milestone

Comments

@ktoso
Copy link
Contributor

ktoso commented Apr 3, 2018

Seems this was attempted in 2016 in #93 however something was not quite done "all the way" it seems.

Always the hardcoded

private[kafka] def rebalanceListener(onAssign: Set[TopicPartition] => Unit, onRevoke: Set[TopicPartition] => Unit): ListenerCallbacks =
    ListenerCallbacks(onAssign, onRevoke)
    def rebalanceListener =
      KafkaConsumerActor.rebalanceListener(tps => partitionAssignedCB.invoke(tps), partitionRevokedCB.invoke)

is used instead of one provided by the user.

It seems like it was intended to be able to pass it in a Subscription, but was never done?

@ktoso ktoso added this to the 0.20 milestone Apr 3, 2018
@ktoso
Copy link
Contributor Author

ktoso commented Apr 3, 2018

cc @kciesielski @patriknw

I'll work on this as got someone requesting it

@ktoso ktoso closed this as completed in #423 Apr 5, 2018
ktoso added a commit that referenced this issue Apr 5, 2018
Add ability to set rebalance listeners from user code #421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant