Increase test timefactor on Travis #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
force-pushed
the
seglo/increase-test-timefactor-travis
branch
from
470597d to
d437c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the
akka.test.timefactorfor Travis tests. This should help mitigate timeouts in certain tests, like those with frequently stream restarts inTransactionsSpec(specifically #826). A project default was defined in #994, but when I repeated the test locally I observed some runs still taking longer than the max allowed time (3x10sec=30sec). This new timefactor should allow for test runs of up to 60 seconds.Instead of increasing the project default we can instead override the configuration on Travis builds only.
EDIT: Passing a system property (or any JVM flag) to the underlying ScalaTest suite and through SBT was more difficult than I thought. I opted to use a global environment variable with an optional override in the test
application.confinstead.https://stackoverflow.com/questions/29857985/how-to-set-system-property-for-a-scalatest-from-sbt-command-line
EDIT 2: Also removes the unused imports failing some of the build.