S3: Format x-amz-date with year-of-era #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"YYYY" in `DateTimeFormatter.ofPattern("YYYYMMdd")` means
week-based-year, which formats `LocalDate.of(2017, 12, 31)` as
"20181231" and results in unexpected rejections from S3 as below:
> The difference between the request time and the current time is
too large.
Replacing it with "yyyy" fixes the bug.
|
Resolves #680 |
ktoso
approved these changes
Dec 31, 2017
There was a problem hiding this comment.
LGTM, thanks for providing the fix so quickly.
Seems the YYYY format indeed is wrong, here's a quick summary for bystanders: http://www.juandebravo.com/2015/04/10/java-yyyy-date-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"YYYY" in
DateTimeFormatter.ofPattern("YYYYMMdd")meansweek-based-year, which formats
LocalDate.of(2017, 12, 31)as"20181231" and results in unexpected rejections from S3 as below:
Replacing it with "yyyy" fixes the bug.