Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQP: support naming connections #881

Merged
merged 1 commit into from
Apr 10, 2018
Merged

AMQP: support naming connections #881

merged 1 commit into from
Apr 10, 2018

Conversation

peter-svensson
Copy link

Make it possible to set a name on the connection to rabbitmq. While resolving issues this is quite useful :)

@lightbend-cla-validator
Copy link

Hi @pliljenberg,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@peter-svensson
Copy link
Author

CLA signed

raboof
raboof approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, are there any other properties that would make sense to be exposed here?

@peter-svensson
Copy link
Author

Hmm. None that I see at the moment at least

@ennru ennru changed the title Added support for naming connections AMQP: support naming connections Apr 10, 2018
@ennru ennru added the p:amqp label Apr 10, 2018
@ennru ennru added this to the 0.19 milestone Apr 10, 2018
@ennru ennru merged commit b6d067b into akka:master Apr 10, 2018
@ennru
Copy link
Member

ennru commented Apr 10, 2018

Hej Peter, thank you for your contribution!

@peter-svensson peter-svensson deleted the clientProvidedName branch April 13, 2018 06:17
@peter-svensson
Copy link
Author

Do we have a date set for v0.19? 😀

@ennru
Copy link
Member

ennru commented Apr 25, 2018

We'll try to shape things up and release v0.19 in the second week of May.
Hopefully, we'll see nightly builds before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
p:amqp
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.
4 participants
@peter-svensson @lightbend-cla-validator @ennru @raboof