Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#849 Fixes to ClusterRouterGroup #953

Merged
merged 1 commit into from
May 8, 2015
Merged

#849 Fixes to ClusterRouterGroup #953

merged 1 commit into from
May 8, 2015

Conversation

annymsMthd
Copy link
Contributor

No description provided.

@annymsMthd annymsMthd mentioned this pull request May 7, 2015
Closed
annymsMthd
annymsMthd reviewed May 7, 2015
View reviewed changes
src/core/Akka/Routing/RoutedActorCell.cs
AddRoutees(routees);
var paths = group.Paths;
if (paths.NonEmpty())
AddRoutees(paths.Select(p => group.RouteeFor(p, this)).ToList());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down the rabbit hole.

@annymsMthd
Copy link
Contributor Author

Going to squash these commits when i get home tonight. @Aaronontheweb mind giving this a look over when you can?

@Aaronontheweb
Copy link
Member

yeessir - can do! I will personally be thrilled to see this spec pass. Been one that's eluded me for a while!

@annymsMthd
Copy link
Contributor Author

I branched off this and merged in my app domain changes. Makes it really
easy with a debugger attached
On Thu, May 7, 2015 at 5:23 PM Aaron Stannard [email protected]
wrote:

yeessir - can do! I will personally be thrilled to see this spec pass.
Been one that's eluded me for a while!

—
Reply to this email directly or view it on GitHub
#953 (comment).

@annymsMthd
Modified RoutedActorCell to match akka canonical
d40e1c0 
fixed ClusterConsistentHashingGroupMultiNode
reworked ActorSelection to fall in line with akka canonical
@annymsMthd annymsMthd changed the title #849 Fixes to ClusterRouterGroup [Not Ready For Merge] #849 Fixes to ClusterRouterGroup May 8, 2015
@Aaronontheweb
Copy link
Member

once we get an overload with the Scheduler running on a DedicatedThreadPool things should be easier for the AppDomain implementation - I strongly suspect threadpool saturation was at play with the inconsistent behavior I got.

@annymsMthd
Copy link
Contributor Author

I'm going to be opening up a PR for it soon just to keep it around until we can get them to consistently pass. I also added the teamcity output.

Aaronontheweb added a commit that referenced this pull request May 8, 2015
@Aaronontheweb
Merge pull request #953 from syncromatics/849-fix-cluster-routee-evic…
c28f79e 
…tion

#849 Fixes to ClusterRouterGroup
@Aaronontheweb Aaronontheweb merged commit c28f79e into akkadotnet:dev May 8, 2015
Aaronontheweb
Aaronontheweb reviewed May 8, 2015
View reviewed changes
src/core/Akka/Util/Internal/ArrayExtensions.cs
/// </summary>
/// <param name="obj">The array to check.</param>
/// <returns>True if not null or empty, false otherwise.</returns>
public static bool NonEmpty(this Array obj)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't linq .Any() work for this? I just realized that right after I closed the PR :\

This was referenced Jun 2, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annymsMthd @Aaronontheweb