Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Text.rich rather than RichText #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

amake
Copy link

@amake amake commented Sep 19, 2023

Text.rich handles selection and text scaling for you automatically.

Fixes #70

Text.rich handles selection and text scaling for you automatically
@JohnF17
Copy link

JohnF17 commented Sep 21, 2023

Hey @amake, was just about to do a PR for this, here is a correction you need to make, RichText and Text.rich are more or less the same and both don't have selection, you should rather change the Text.rich to SelectableText.rich, Cheers👍.

@amake
Copy link
Author

amake commented Sep 21, 2023

RichText and Text.rich are more or less the same and both don't have selection, you should rather change the Text.rich to SelectableText.rich

Please read my comment on #70. SelectableText.rich is not the right thing to use here.

@JohnF17
Copy link

JohnF17 commented Sep 21, 2023

Should have read the entire issue and not just the title before I commented, it makes sense to make it optional, well thought.
Let's hope they merge it soon, package looks abandoned, how ironic 👀

@amake amake mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text selection
2 participants