-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #143: Add data creation CLI #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converting to draft as a few things to fix regarding the types of the default arguments. trying to fix this now |
rwood-97
reviewed
Jan 4, 2024
rwood-97
reviewed
Jan 4, 2024
Looks good - I changed the instances of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #143:
reginald_create_index
CLI to create an indexreginald_create_index
LlamaIndex
to make aDataIndexCreator
classsetup_service_context
helper function which gets called in both setting up LlamaIndex model and when creating the index on its ownget_env_var
helper function which just logs when it's trying to read a environment variable and says if it's able to find it. If not able to, default arguments are usedget_args
loops through the arguments and calls the arguments and calls any lambda functions to get the default argumentsk
,chunk_size
,chunk_overlap_ratio
,num_output
are now able to be passed as CLI arguments inreginald_run
,reginald_run_api_llm
andreginald_create_index