Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows): reference subworkflows in main workflows #12

Merged
merged 4 commits into from
Feb 4, 2025
Merged

feat(workflows): reference subworkflows in main workflows #12

merged 4 commits into from
Feb 4, 2025

Conversation

aldbr
Copy link
Owner

@aldbr aldbr commented Jan 20, 2025 •
edited
Loading

  • tests should pass
  • add a test where the subworkflow does not exist and make sure it is correctly handled
  • add a test where the subworkflow references the parent workflow (circular dependency)
  • add a test where the subworkflow references itself

@aldbr aldbr marked this pull request as ready for review January 26, 2025 16:24
@aldbr aldbr requested a review from mexanick January 26, 2025 18:06
@arrabito
Copy link
Collaborator

arrabito commented Feb 4, 2025

Thank you @aldbr for this MR.
All seems good to me.

@aldbr aldbr merged commit a8d9fff into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrabito arrabito arrabito approved these changes

@mexanick mexanick Awaiting requested review from mexanick

@natthan-pigoux natthan-pigoux Awaiting requested review from natthan-pigoux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldbr @arrabito