Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow msg to be specified for Maybe #373

Merged
merged 1 commit into from
Dec 15, 2018
Merged

Allow msg to be specified for Maybe #373

merged 1 commit into from
Dec 15, 2018

Conversation

svisser
Copy link
Collaborator

@svisser svisser commented Dec 14, 2018

This is a proposed fix for #369. This makes it possible to supply a good error message to the user.

@svisser
Allow msg to be specified for Maybe
43ea94b 
This makes it possible to supply a good error message to the user.
This got reported in alecthomas#369
@svisser svisser self-assigned this Dec 14, 2018
@svisser svisser requested a review from alecthomas December 14, 2018 20:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.349% when pulling 43ea94b on svisser:feature/maybe_msg into 2e68114 on alecthomas:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.349% when pulling 43ea94b on svisser:feature/maybe_msg into 2e68114 on alecthomas:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.349% when pulling 43ea94b on svisser:feature/maybe_msg into 2e68114 on alecthomas:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.349% when pulling 43ea94b on svisser:feature/maybe_msg into 2e68114 on alecthomas:master.

alecthomas
alecthomas approved these changes Dec 14, 2018
View reviewed changes
Copy link
Owner

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svisser svisser merged commit d8e042c into alecthomas:master Dec 15, 2018
@svisser svisser deleted the feature/maybe_msg branch December 15, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees

@svisser svisser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svisser @coveralls @alecthomas